Skip to content

Bugfix cloud webhooks text response #20737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pvizeli wants to merge 3 commits into from
Closed

Bugfix cloud webhooks text response #20737

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c11447
Bugfix cloud webhooks text response
pvizeli Feb 4, 2019
8dcba89
Fix tests for aiohttp
pvizeli Feb 4, 2019
38d96e4
address comments
pvizeli Feb 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions homeassistant/components/cloud/iot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,8 +362,6 @@ async def async_handle_webhook(hass, cloud, payload):

response_dict = serialize_response(response)
body = response_dict.get('body')
if body:
body = body.decode('utf-8')

return {
'body': body,
Expand Down
2 changes: 1 addition & 1 deletion homeassistant/util/aiohttp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,6 @@ def serialize_response(response: web.Response) -> Dict[str, Any]:
"""Serialize an aiohttp response to a dictionary."""
return {
'status': response.status,
'body': response.body,

@balloob balloob Feb 4, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a generic helper, we should not change its behavior to make it more shaped for one implementation. If we want that, we should move this function inside the cloud integration.

'body': response.text,
'headers': dict(response.headers),
}