Add tests for ZHA switch#20691
Merged
Merged
Conversation
ghost
assigned
test cleanup test deps update switch test actually update test deps cleanup and remove switch from coveragerc comment refactor to use fixtures and shared components lint
dmulcahey
force-pushed
the
dm/zha-switch-test
branch
from
b77157a to
3812907
Compare
Contributor
Author
|
@MartinHjelmare addressed comments |
MartinHjelmare
approved these changes
Feb 3, 2019
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Small comment left. Then we can merge.
Member
|
Btw, what's the coverage percent in the switch platform? |
Contributor
Author
|
86.57 in dev and 97.78 in the reorg branch. |
Member
|
Then let's wait with removing the entry from .coveragerc. We don't want any modules below 95 %. |
Contributor
Author
|
ok, I’ll put that back in the morning. Good to merge after that and the build passing again? |
Member
|
Yes! |
MartinHjelmare
approved these changes
Feb 3, 2019
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Can be merged when build passes.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the tests for switch and also the common components and fixtures needed for testing all domains