Add PLATFORM_SCHEMA_BASE support to check_config.py#20663
Merged
Conversation
ghost
assigned
kellerza
reviewed
Feb 1, 2019
| # Validate component specific platform schema | ||
| try: | ||
| p_validated = component.PLATFORM_SCHEMA(p_config) | ||
| if hasattr(component, 'PLATFORM_SCHEMA_BASE'): |
Member
There was a problem hiding this comment.
Should platform_schema not have a higher priority?
Never used platform_schema_base, not sure what the rules are
Contributor
Author
There was a problem hiding this comment.
No, PLATFORM_SCHEMA_BASE should have higher priority.
Background here: #20224
balloob
approved these changes
Feb 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add PLATFORM_SCHEMA_BASE support to check_config.py
This was missed when adding PLATFORM_SCHEMA_BASE in #20224
Related issue (if applicable): fixes #20647
Checklist:
tox. Your PR cannot be merged unless tests pass