Skip to content

Fix parsing yeelight custom effects, when not present in config#20658

Merged
MartinHjelmare merged 1 commit into
home-assistant:devfrom
zewelor:fix_parsing_yeelight_custom_effects_when_not_provided
Feb 1, 2019
Merged

Fix parsing yeelight custom effects, when not present in config#20658
MartinHjelmare merged 1 commit into
home-assistant:devfrom
zewelor:fix_parsing_yeelight_custom_effects_when_not_provided

Conversation

@zewelor
Copy link
Copy Markdown
Contributor

@zewelor zewelor commented Feb 1, 2019

Related issue (if applicable): fixes #20628

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

Copy link
Copy Markdown
Member

@rohankapoorcom rohankapoorcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@rohankapoorcom
Copy link
Copy Markdown
Member

Can be merged when build passes.

@rohankapoorcom rohankapoorcom added this to the 0.87.0 milestone Feb 1, 2019
@MartinHjelmare MartinHjelmare merged commit 7429b9d into home-assistant:dev Feb 1, 2019
@ghost ghost removed the in progress label Feb 1, 2019
@zewelor zewelor deleted the fix_parsing_yeelight_custom_effects_when_not_provided branch February 1, 2019 10:21
@balloob balloob mentioned this pull request Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Yeelight custom_effects has no default value

5 participants