Fix allow extra in locative webhook schema validation#20657
Merged
rohankapoorcom merged 2 commits intoFeb 1, 2019
Conversation
homeassistant
added
cla-signed
integration: locative
small-pr
ghost
assigned
amelchio
reviewed
Feb 1, 2019
MartinHjelmare
changed the title
Member
|
Can be merged when build passes. |
balloob
pushed a commit
that referenced
this pull request
Feb 2, 2019
* Allow extra in locative webhook schema validation (fixes #20566) * Remove extra attribute
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Locative sends several extra keys that we don't care about when it sends the webhook request. Since we hadn't set
extra=vol.ALLOW_EXTRAor defined those keys in the schema, it was getting rejected. Since we don't care about the values in those keys, we should just allow the extra keys to be sent.Related issue (if applicable): fixes #20566
Checklist:
tox. Your PR cannot be merged unless tests pass