Fix sensor.cpuspeed inside docker container (#20614)#20656
Merged
Conversation
homeassistant
added
platform: sensor.cpuspeed
small-pr
ghost
assigned
fabaff
approved these changes
Feb 1, 2019
| } | ||
|
|
||
| if HZ_ADVERTISED_RAW in self.info: | ||
| attrs[ATTR_HZ] = round( |
Member
There was a problem hiding this comment.
We shouldn't duplicate the state in state attributes. I think we should remove this here.
Member
There was a problem hiding this comment.
Nevermind, it's not the same key. Read too fast. 🤦♂️
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Check for missing attributes in docker container before using them in CPU Speed sensor.
Related issue (if applicable): fixes #20614
Checklist:
tox. Your PR cannot be merged unless tests pass