Skip to content

Add SmartThings Light platform#20652

Merged
balloob merged 5 commits intohome-assistant:devfrom
andrewsayre:feature-smartthings-light
Feb 2, 2019
Merged

Add SmartThings Light platform#20652
balloob merged 5 commits intohome-assistant:devfrom
andrewsayre:feature-smartthings-light

Conversation

@andrewsayre
Copy link
Copy Markdown
Member

Description:

Adds the SmartThings Light platform that represents SmartThings devices that have light-related capabilities. Highlights:

  • Supports light brightness, transition, color, and color_temp features based on the underlying capabilities of the SmartThings device. See the source/docs PR for details on the capability mapping.
  • No action required from users to add devices -- simply restart HASS once the platform is released and the light entities will automatically be created and start receiving updates.

CC @arsaboo @ryanwinter

Pull request in home-assistant.io with documentation: home-assistant/home-assistant.io#8365

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Comment thread homeassistant/components/smartthings/light.py Outdated
Comment thread homeassistant/components/smartthings/light.py Outdated
Comment thread homeassistant/components/smartthings/light.py
Comment thread homeassistant/components/smartthings/light.py Outdated
Comment thread tests/components/smartthings/test_light.py Outdated
Comment thread homeassistant/components/smartthings/light.py Outdated
@arsaboo
Copy link
Copy Markdown
Contributor

arsaboo commented Feb 1, 2019

Just tested this and works perfectly...thanks @andrewsayre

Comment thread homeassistant/components/smartthings/light.py
Comment thread homeassistant/components/smartthings/light.py Outdated
Comment thread homeassistant/components/smartthings/light.py Outdated
@balloob balloob added this to the 0.87.0 milestone Feb 2, 2019
@balloob balloob merged commit a24da61 into home-assistant:dev Feb 2, 2019
@ghost ghost removed the in progress label Feb 2, 2019
@andrewsayre andrewsayre deleted the feature-smartthings-light branch February 2, 2019 16:07
balloob pushed a commit that referenced this pull request Feb 2, 2019
* Add SmartThings Light platform and tests

* Cleaned a few awk comments

* Updates per review feedback

* Switched to super

* Changes per review feedback
@balloob balloob mentioned this pull request Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants