Skip to content

Update synology-srm dependency to 0.0.4#20625

Merged
fabaff merged 1 commit into
home-assistant:devfrom
aerialls:synology-srm-119
Jan 31, 2019
Merged

Update synology-srm dependency to 0.0.4#20625
fabaff merged 1 commit into
home-assistant:devfrom
aerialls:synology-srm-119

Conversation

@aerialls
Copy link
Copy Markdown
Contributor

Description

This PR fixes error 119 with the Synology SRM API. When the API token starts with a digit, it can not be used with a GET parameter. The token is now put in a cookie.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@fabaff fabaff merged commit c997167 into home-assistant:dev Jan 31, 2019
@ghost ghost removed the in progress label Jan 31, 2019
@aerialls aerialls deleted the synology-srm-119 branch February 19, 2019 12:20
@balloob balloob mentioned this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants