Move mqtt_mock to tests/components/mqtt/conftest.py#20621
Merged
MartinHjelmare merged 4 commits intoJan 31, 2019
Conversation
ghost
assigned
houndci-bot
reviewed
Jan 31, 2019
awarecan
force-pushed
the
cleanup-mqtt-test-fixture
branch
from
24b3b9d to
c68c671
Compare
MartinHjelmare
approved these changes
Jan 31, 2019
MartinHjelmare
requested changes
Jan 31, 2019
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Right, there are still mqtt platforms not moved under the mqtt component. So this one could get more complicated.
It would be a good move though.
Member
|
Should we really move the tests without moving the corresponding source modules? |
Contributor
Author
|
Maybe we should move source code as well. All other mqtt switch, light, etc, even sensor.mqtt are under mqtt component folder. However this |
Member
|
I think it's harder to move that due to the name. We can't name that platform |
Contributor
Author
|
Revert the moving, fix the mqtt room presence sensor test instead. |
MartinHjelmare
approved these changes
Jan 31, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
mqtt_mock test fixture should only be used in mqtt component tests.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: