Skip to content

Use PLATFORM_SCHEMA_BASE as base schema for MQTT platforms.#20562

Merged
balloob merged 1 commit into
home-assistant:devfrom
emontnemery:component_schema_mqtt
Jan 29, 2019
Merged

Use PLATFORM_SCHEMA_BASE as base schema for MQTT platforms.#20562
balloob merged 1 commit into
home-assistant:devfrom
emontnemery:component_schema_mqtt

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Jan 29, 2019

Description:

Use PLATFORM_SCHEMA_BASE as base schema for MQTT platforms.
PLATFORM_SCHEMA_BASE doesn't set extra=vol.ALLOW_EXTRA which means misspelled or unknown configuration variables will no longer be silently accepted.

This is a follow-up to #20224 .

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@emontnemery emontnemery requested a review from a team as a code owner January 29, 2019 06:13
@ghost ghost assigned emontnemery Jan 29, 2019
@ghost ghost added the in progress label Jan 29, 2019
@emontnemery emontnemery changed the title Disable extra=vol.ALLOW_EXTRA for MQTT platforms. Use PLATFORM_SCHEMA_BASE as base schema for MQTT platforms. Jan 29, 2019
@balloob balloob merged commit 89fc3b2 into home-assistant:dev Jan 29, 2019
@ghost ghost removed the in progress label Jan 29, 2019
@emontnemery emontnemery deleted the component_schema_mqtt branch January 30, 2019 11:52
@emontnemery
Copy link
Copy Markdown
Contributor Author

Added breaking change label as suggested in discord beta channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants