Split out dovado to a component and sensor platform#20339
Merged
Conversation
houndci-bot
reviewed
Jan 23, 2019
rohankapoorcom
commented
Jan 23, 2019
Member
|
I think we can merge when build passes and we've added a paragraph in the PR description about the breaking changes for the release notes. |
Member
Author
|
I guess its time to go update the docs as well. |
2 tasks
Member
Author
|
Docs linked, build seems to be failing due to an unrelated file have a lint error. |
a3d518d to
18cfa1a
Compare
Member
Author
|
Rebasing with |
Member
|
For the future maybe we should move configuration to the component and load the platforms via discovery instead? But it's not required I think. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Per home-assistant/architecture#131, sensor platforms should not be registering services. Dovado is one of several that does and this should be cleaned up. I moved all of the setup/service logic to a new Dovado component and then used that component inside the sensor platform.
I am unable to verify that any of these changes work since I do not have a Dovado router.
Breaking Change: The Dovado sensor platform has been broken up into a Dovado component with sensor and notify platforms. The configuration variables have been changed. Please refer to the documentation for the correct configuration.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8296
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.