Fix: Log exceptions thrown by signal callbacks#20284
Merged
balloob merged 1 commit intohome-assistant:devfrom Jan 21, 2019
andrewsayre:fix_dispatcher_log_exceptions
Merged
Fix: Log exceptions thrown by signal callbacks#20284balloob merged 1 commit intohome-assistant:devfrom andrewsayre:fix_dispatcher_log_exceptions
balloob merged 1 commit intohome-assistant:devfrom
andrewsayre:fix_dispatcher_log_exceptions
Conversation
ghost
added
the
andrewsayre
changed the title
balloob
approved these changes
Jan 21, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixed a bug introduced by #20015 where it was not properly detecting coroutine functions wrapped inside a
functools.partial. This resulted incatch_log_exceptionwrapping incorrectly, which downstream results in coroutine not being awaited.This also improved worked done in #20119 so that
async_add_jobnow recursively checks for partials to bring it in parity with the work done incatch_log_exception.Checklist:
tox. Your PR cannot be merged unless tests pass