Make Netatmo battery_percent icon dynamic#20275
Merged
amelchio merged 1 commit intohome-assistant:devfrom Jan 20, 2019
notoriousbdg:dev
Merged
Make Netatmo battery_percent icon dynamic#20275amelchio merged 1 commit intohome-assistant:devfrom notoriousbdg:dev
amelchio merged 1 commit intohome-assistant:devfrom
notoriousbdg:dev
Conversation
Danielhiversen
approved these changes
Jan 20, 2019
Merged
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Feb 12, 2019
kellerza
pushed a commit
to kellerza/ha-core
that referenced
this pull request
Feb 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This change makes the icon for the Netatmo battery_percent sensors dynamic by setting device_class on the sensors instead of hard coding the icon.
Related issue (if applicable): fixes N/A
Pull request in home-assistant.io with documentation (if applicable): N/A
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests pass