Skip to content

Make Netatmo battery_percent icon dynamic#20275

Merged
amelchio merged 1 commit intohome-assistant:devfrom
notoriousbdg:dev
Jan 20, 2019
Merged

Make Netatmo battery_percent icon dynamic#20275
amelchio merged 1 commit intohome-assistant:devfrom
notoriousbdg:dev

Conversation

@notoriousbdg
Copy link
Copy Markdown
Contributor

Description:

This change makes the icon for the Netatmo battery_percent sensors dynamic by setting device_class on the sensors instead of hard coding the icon.

Related issue (if applicable): fixes N/A

Pull request in home-assistant.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

netatmo:
  api_key: YOUR_CLIENT_ID
  secret_key: YOUR_CLIENT_SECRET
  username: YOUR_USERNAME
  password: YOUR_PASSWORD

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@amelchio amelchio merged commit 5b8cb10 into home-assistant:dev Jan 20, 2019
@ghost ghost removed the in progress label Jan 20, 2019
@balloob balloob mentioned this pull request Feb 6, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019
kellerza pushed a commit to kellerza/ha-core that referenced this pull request Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants