Remove colorlog dep if available#20272
Closed
kellerza wants to merge 1 commit into
Closed
Conversation
balloob
reviewed
Jan 21, 2019
| try: | ||
| import colorlog.escape_codes # noqa # pylint: disable=unused-import | ||
| except ImportError: | ||
| REQUIREMENTS = ('colorlog==4.0.2',) |
Member
There was a problem hiding this comment.
This will confuse our requirement generator script.
The dev docker image should already have colorlog, so should not install it every time?
Member
Author
There was a problem hiding this comment.
Indeed, it's not added, but there might also be a problem with how we detect colorlog inside Docker If I read this correctly?
root@linuxkit-00155d5dc21f:/usr/src/app# pip list | grep colorlog
colorlog 4.0.2
root@linuxkit-00155d5dc21f:/usr/src/app# hass --script check_config --config /config
INFO:homeassistant.util.package:Attempting install of colorlog==4.0.2
Testing configuration at /config
Failed config
homeassistant:
- extra keys not allowed @ data['packages']['yr__pack']Another approach would be to make this part of the core requirements... (would prefer this to be honest)
Member
There was a problem hiding this comment.
We shouldn't merge this. We're breaking something because some other wrapper or runner doesn't install correctly or keep it around.
This is not something that should be fixed inside Home Assistant as it works as expected.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Removed colorlog REQUIREMENT if this is already present
There are multiple reports of colorlog installing everytime on config_check execution — I am seeing this in the dev docker image as well
Another approach would be to make this part of the core requirements... (would prefer this to be honest)
Related issue (if applicable): fixes #18651
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: