Skip to content

Add type hints to helpers.condition#20266

Merged
fabaff merged 1 commit intohome-assistant:devfrom
scop:typing-helpers
Jan 20, 2019
Merged

Add type hints to helpers.condition#20266
fabaff merged 1 commit intohome-assistant:devfrom
scop:typing-helpers

Conversation

@scop
Copy link
Copy Markdown
Member

@scop scop commented Jan 20, 2019

Description:

Title says it all.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@fabaff fabaff merged commit 58bb6f2 into home-assistant:dev Jan 20, 2019
@ghost ghost removed the in progress label Jan 20, 2019
@scop scop deleted the typing-helpers branch January 22, 2019 20:46
@balloob balloob mentioned this pull request Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants