Owlet Care Baby Monitor Component#20258
Conversation
|
I would recommend moving all of these files to: |
rohankapoorcom
left a comment
There was a problem hiding this comment.
A few more thoughts (inline) and here:
I would recommend moving all of these files to:
homeassistant/components/owlet/__init__.py (component) and then binary_sensor.py and sensor.py in the same package. More details in (#19948). This makes it easier to understand what platforms a component supports. For a good example, take a look at the hue component.
|
@rohankapoorcom I've made the changes as suggested and the component is working. However, I'm getting the following error and I cannot figure out how to resolve it. Any guidance on how to resolve this would be appreciated. EDIT: Configuration has been updated in PR description. Error happens with updated config as well as with original entries for |
|
I'm not familiar with the translation code at all. I believe there was a fix that @balloob had done to fix them with embedded components a while back. Can you rebase off of the latest dev branch and see if the same error occurs? |
|
I tried that right after my last comment, but it did not help. Creating the strings file and generating translations did not resolve it either. Maybe somebody else knows what is wrong? Otherwise, this is working and is ready to merge. |
|
@home-assistant/core any suggestions regarding the translations? |
|
@rohankapoorcom Can you approve the changes you requested so this PR will appear ready? Maybe somebody will chime in with a solution to the error before merging. |
|
Can be merged when lint errors are fixed and the branch is rebased to fix coveralls. |
|
@MartinHjelmare Something blew up when I tried to rebase. I'm going to close this PR since I don't trust the state of the working branch. I've moved all of the changes to a clean working branch and have opened #21108 to replace this one. |
Description:
Add support for monitoring stats from Owlet Care baby monitoring sock.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8217
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.