Add separate on/off ids on manual configured IHC lights#20253
Merged
Conversation
Contributor
ghost
added
the
2 tasks
MartinHjelmare
requested changes
Feb 21, 2019
msvinth
requested review from
Danielhiversen,
Kane610,
OttoWinter,
OverloadUT,
amelchio,
andrewsayre,
andrey-git,
bachya,
cdce8p,
dgomes,
emlove,
fabaff,
frenck,
kellerza,
ludeeus,
rohankapoorcom,
rytilahti,
scop and
syssi
as code owners
Contributor
Author
|
Sorry everyone I asked for a review. I meshed up my git commands and did a pull instead of rebase. Only @MartinHjelmare is needed for the review. |
OverloadUT
removed request for
a team,
Kane610,
OverloadUT,
amelchio,
cdce8p and
ludeeus
MartinHjelmare
changed the title
Member
|
Try rebasing to make the build pass. |
This makes it easier to support IHC code units thats relies on being turned on and off through specific inputs. Also adds a pulse service (ihc.pulse) that supports sending a short on/off pulse to an IHC input.
Contributor
Author
|
Did the rebasing and the build is now passing. Thank you for the review. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add support for separate on/off ids on manual configured IHC lights.
This makes it easier to support IHC code units thats relies on being
turned on and off through specific inputs.
Also adds a pulse service (ihc.pulse) that supports sending a short on/off pulse to an IHC input.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8218
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: