Skip to content

Add verify_ssl to restful_command and switch.rest (#20199)#20207

Merged
pvizeli merged 1 commit intohome-assistant:devfrom
rohankapoorcom:restful-verify-ssl
Jan 18, 2019
Merged

Add verify_ssl to restful_command and switch.rest (#20199)#20207
pvizeli merged 1 commit intohome-assistant:devfrom
rohankapoorcom:restful-verify-ssl

Conversation

@rohankapoorcom
Copy link
Copy Markdown
Member

@rohankapoorcom rohankapoorcom commented Jan 18, 2019

Description:

Add verify_ssl to restful_command and switch.rest

Related issue (if applicable): fixes #20199

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8205

Example entry for configuration.yaml (if applicable):

switch:
  - platform: rest
    resource: http://IP_ADDRESS/ENDPOINT
    verify_ssl: true

rest_command:
  example_request:
    url: 'http://example.com/'
    verify_ssl: true

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@pvizeli pvizeli merged commit 84b1fcb into home-assistant:dev Jan 18, 2019
@ghost ghost removed the in progress label Jan 18, 2019
@rohankapoorcom rohankapoorcom deleted the restful-verify-ssl branch January 18, 2019 16:31
@balloob balloob mentioned this pull request Feb 6, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing verify_ssl option in RESTful Command and RESTful Switch components

3 participants