Skip to content

Embed ZoneMinder platforms into component#20182

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
rohankapoorcom:embed-zoneminder
Jan 17, 2019
Merged

Embed ZoneMinder platforms into component#20182
MartinHjelmare merged 1 commit intohome-assistant:devfrom
rohankapoorcom:embed-zoneminder

Conversation

@rohankapoorcom
Copy link
Copy Markdown
Member

@rohankapoorcom rohankapoorcom commented Jan 17, 2019

Description:

This PR leverages #19948 to embed the ZoneMinder platforms under the component.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@MartinHjelmare MartinHjelmare merged commit 2de6a94 into home-assistant:dev Jan 17, 2019
@ghost ghost removed the in progress label Jan 17, 2019
@rohankapoorcom rohankapoorcom deleted the embed-zoneminder branch January 17, 2019 10:13
@balloob balloob mentioned this pull request Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants