Remove color call to set lights to black when turning hyperion lights off.

[boralyl]

Description:

Calling clear all is enough to turn off the hyperion light. Calling the color
command after calling clear all makes the light no longer function until clear all is called
again. The component calls clear all before turning the light on, which is
why it works through home assistant. However if you try to control the
light via the hyperion app, kodi, or it's JSON API after it has been turned off
via home assistant it will not function until you call clear all again through an app or it's JSON API.

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.

[homeassistant]

Hi @boralyl,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[balloob]

Thanks!

[RomRider]

@boralyl @balloob with this PR it is now impossible to properly turn off the light (I switches back and forth from Off to HDMI as soon as you turn off the light).
When my HDMI grabber doesn't receive a signal, it display a green-ish message, and I can see the leds lighting up even if the light was just turned off in HA. It was not the case before this PR.

There is only one way to clear hyperion. It by setting the color to back like it was before this PR.

Please revert. :)

[boralyl]

@RomRider Interesting. Prior to this change I was unable to control the light after turning it off with home assistant. I wonder if it was toggling, but it was turning on 'black' so that it did not appear to be on. I run hyperion with the xbmcVideoChecker configuration, are you using grabber-v4l2?

I'll do some debugging to see if I can reproduce the issue you are seeing as well as work for toggling. Perhaps the default color (looks like it's supposed to be white) isn't working as expected and it defaults to black when I toggle it on.

[MartinHjelmare]

Please open an issue if you suspect a bug.

If you want to suggest an enhancement please open a feature request in the Feature Requests section of our community forum.

Merged PRs should not be used for enhancement discussion or bug reports. If you've found a bug it's ok to make a review with inline comments and link to an issue that reports the bug.

Thanks!