Migrate gpslogger to the automatically generated webhook#20079
Merged
Conversation
houndci-bot
reviewed
Jan 14, 2019
2 tasks
Merged
2 tasks
Member
Author
|
Docs added and linked. |
Member
Author
|
@balloob this needs the breaking change label. |
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Migrate GPSLogger over to the webhook component so that it doesn't need an API password or a long lived access token
Breaking Change:
Each instance of Home Assistant will now generate it's own unique webhook for GPSLogger to use. One will need to be generated and provided to the mobile app to the replace the existing url: https://myhome.duckdns.org/api/gpslogger?api_password=HA_PASSWORD. Home Assistant only supports using POST (no longer GET) for GPSLogger. The long lived access token is also no longer needed.
Related issue (if applicable): related to #15376
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8186
I will create a docs PR once this previous PR is merged home-assistant/home-assistant.io#8152
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: