Skip to content

Migrate gpslogger to the automatically generated webhook#20079

Merged
balloob merged 3 commits into
home-assistant:devfrom
rohankapoorcom:gpslogger-webhook
Jan 16, 2019
Merged

Migrate gpslogger to the automatically generated webhook#20079
balloob merged 3 commits into
home-assistant:devfrom
rohankapoorcom:gpslogger-webhook

Conversation

@rohankapoorcom
Copy link
Copy Markdown
Member

@rohankapoorcom rohankapoorcom commented Jan 14, 2019

Description:

Migrate GPSLogger over to the webhook component so that it doesn't need an API password or a long lived access token

Breaking Change:
Each instance of Home Assistant will now generate it's own unique webhook for GPSLogger to use. One will need to be generated and provided to the mobile app to the replace the existing url: https://myhome.duckdns.org/api/gpslogger?api_password=HA_PASSWORD. Home Assistant only supports using POST (no longer GET) for GPSLogger. The long lived access token is also no longer needed.

Related issue (if applicable): related to #15376

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8186

I will create a docs PR once this previous PR is merged home-assistant/home-assistant.io#8152

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Comment thread homeassistant/components/gpslogger/__init__.py Outdated
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge when docs added.

@rohankapoorcom
Copy link
Copy Markdown
Member Author

Docs added and linked.

@rohankapoorcom
Copy link
Copy Markdown
Member Author

@balloob this needs the breaking change label.

@balloob balloob merged commit b5bfc75 into home-assistant:dev Jan 16, 2019
@ghost ghost removed the in progress label Jan 16, 2019
@rohankapoorcom rohankapoorcom deleted the gpslogger-webhook branch January 16, 2019 20:09
Comment thread homeassistant/components/gpslogger/__init__.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants