Skip to content

Support next generation of the Xiaomi Mi Smart Plug (chuangmi.plug.m3)#19972

Merged
rytilahti merged 2 commits into
home-assistant:devfrom
syssi:feature/xiaomi-miio-chuangmi-plug-m3-support
Jan 11, 2019
Merged

Support next generation of the Xiaomi Mi Smart Plug (chuangmi.plug.m3)#19972
rytilahti merged 2 commits into
home-assistant:devfrom
syssi:feature/xiaomi-miio-chuangmi-plug-m3-support

Conversation

@syssi
Copy link
Copy Markdown
Member

@syssi syssi commented Jan 11, 2019

Description:

Related issue (if applicable): fixes syssi/xiaomiplug#16

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8133

@syssi syssi requested a review from rytilahti as a code owner January 11, 2019 12:47
@ghost ghost assigned syssi Jan 11, 2019
@ghost ghost added the in progress label Jan 11, 2019
elif model in ['chuangmi.plug.m1', 'chuangmi.plug.v2',
'chuangmi.plug.hmi205']:
elif model in ['chuangmi.plug.m1', 'chuangmi.plug.m3',
'chuangmi.plug.v2', 'chuangmi.plug.hmi205']:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line over-indented for visual indent

@rytilahti
Copy link
Copy Markdown
Member

LGTM. The tests were run successfully, but for some reason travis did not update the status here.

@rytilahti rytilahti merged commit e2f55a9 into home-assistant:dev Jan 11, 2019
@ghost ghost removed the in progress label Jan 11, 2019
@balloob balloob mentioned this pull request Jan 23, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019
home-assistant#19972)

* Support next generation of the Xiaomi Mi Smart Plug (chuangmi.plug.m3)

* Fix indent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Xiaomi Chuangmi Plug M3 support

4 participants