Skip to content

Support for relay ports for LCN light platform#19632

Merged
MartinHjelmare merged 4 commits intohome-assistant:devfrom
alengwenus:dev_lcn_relaylights
Jan 20, 2019
Merged

Support for relay ports for LCN light platform#19632
MartinHjelmare merged 4 commits intohome-assistant:devfrom
alengwenus:dev_lcn_relaylights

Conversation

@alengwenus
Copy link
Copy Markdown
Contributor

@alengwenus alengwenus commented Dec 29, 2018

Description:

Support is added for lights which are connected to the relays of LCN hardware devices.

Related issue (if applicable):

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7977

Example entry for configuration.yaml (if applicable):

lcn:
  connections:
    - name: myhome
      host: 192.168.2.41
      port: 4114
      username: !secret lcn_username
      password: !secret lcn_password

  lights:
    - name: Living room
      address: myhome.0.7
      output: relay1

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

Copy link
Copy Markdown
Contributor

@dgomes dgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@MartinHjelmare MartinHjelmare merged commit a8d3a90 into home-assistant:dev Jan 20, 2019
@ghost ghost removed the Ready for review label Jan 20, 2019
@alengwenus alengwenus deleted the dev_lcn_relaylights branch January 20, 2019 18:23
@balloob balloob mentioned this pull request Feb 6, 2019
@ghost ghost removed the platform: light.lcn label Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants