Mqtt alarm added value_template and code_arm_required

[ToRvaLDz]

Description:

Added value_template config option to parse json incoming message.
Added code_arm_required config option to avoid code enter on arm.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8822

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• New dependencies have been added to the REQUIREMENTS variable (example).
• New dependencies are only imported inside functions that use them (example).
• New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
• New files were added to .coveragerc.

If the code does not interact with devices:

• Tests have been added to verify that the new code works.

[emontnemery]

It looks pretty OK, please add tests and fix the lint error (move the docstring).

[ToRvaLDz]

It looks pretty OK, please add tests and fix the lint error (move the docstring).

I fixed the lint error but I'm not a python developer and I'm not sure I can add tests :(

[emontnemery]

I fixed the lint error but I'm not a python developer and I'm not sure I can add tests :(

The changes are OK, but you need to add new tests before merge.

Have a look here:
https://developers.home-assistant.io/docs/en/development_testing.html

Note that if you don't want to wait for Travis/tox to do the full suite of tests you can do:
script/lint to just lint your modifications
py.test tests/components/alarm_control_panel/test_mqtt.py to just test the alarm stuff
https://developers.home-assistant.io/docs/en/development_testing.html#testing-outside-of-tox

Inspiration for the test cases:
https://github.com/home-assistant/home-assistant/blob/76c30aca38d9c386ab4825439694646083a9bc59/tests/components/switch/test_mqtt.py#L98
https://github.com/home-assistant/home-assistant/blob/76c30aca38d9c386ab4825439694646083a9bc59/tests/components/alarm_control_panel/test_mqtt.py#L117
https://github.com/home-assistant/home-assistant/blob/76c30aca38d9c386ab4825439694646083a9bc59/tests/components/alarm_control_panel/test_mqtt.py#L58

[balloob]

Please add tests for new functionality

[ToRvaLDz]

Please add tests for new functionality

I'm sorry for late reply, can you please check if tests are ok? Tnx

[balloob]

Hey @ToRvaLDz, the tests are great! Ok to merge when merge conflicts resolved.

[ToRvaLDz]

@balloob conflicts should be fixed

Tests have been added and approved.

[JumpMaster]

Sorry to jump in after this has been merged. But shouldn't this also be applied to async_alarm_arm_night?

[ToRvaLDz]

@JumpMaster your're right,tnx. @balloob how can I fix it, need to open another PR?

[MartinHjelmare]

Please open a new PR.