Add huawei_lte notify component

[scop]

Description:

Add notify component using Huawei LTE router SMS.

Related issue (if applicable): https://community.home-assistant.io/t/adding-notification-to-huawei-lte-router/70950

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7934

Example entry for configuration.yaml (if applicable):

notify:
  - platform: huawei_lte
    target: "+15105550123"

Checklist:

• The code change is tested and works locally. Caveat: tested without an SMS enabled plan, so verified only that the API calls succeed and fail when/like they should, and sent messages end up in the router's SMS outbox.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• New dependencies have been added to the REQUIREMENTS variable (example).
• New dependencies are only imported inside functions that use them (example).
• New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
• New files were added to .coveragerc.

If the code does not interact with devices:

• Tests have been added to verify that the new code works.

[andyinno]

Changing

from ..huawei_lte import DATA_KEY

to

from homeassistant.components.huawei_lte import DATA_KEY

Allowed me to test it as custom component.
I tested the sending of the sms 4 times and 2 times it was successful. The other two times I reached line 60 and the error message appeared.

[scop]

Anything I can do to get this moving forward? I don't think there's anything to be done for send failures besides logging them here, if they're not about some syntax errors caused by the implementation (which I think they aren't, but can't obviously tell for sure without seeing the error messages).

[andyinno]

I tested it some times more and I receive the notification. It looks to me that it is working correctly. The errors in my opinion are related to what it is behind because also the sensors from the huawei_lte module gives some error sometimes. The way this module operates looks correct to me. I don't know if it can be reinforced with something like... Error then try again once. Il mer 16 gen 2019, 21:34 Ville Skyttä <notifications@github.com> ha scritto:

…

Anything I can do to get this moving forward? I don't think there's anything to be done for send failures besides logging them here, if they're not about some syntax errors caused by the implementation (which I think they aren't, but can't obviously tell for sure without seeing the error messages). — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#19544 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFtLWlCc53I7G-HuM3Pl34vrLyaPlEszks5vD4zIgaJpZM4Zf4jL> .

[MartinHjelmare]

Looks good! Just a small comment.

[MartinHjelmare]

We should use CONF_ constants for config keys

[scop]

Changed to CONF_RECIPIENT as that seems to be used for this purpose in other notify component configs. But note that the similar netgear_lte and tplink_lte components use ATTR_TARGET, that's where I initially picked it up from. Maybe it should somehow be fixed in them too.

[MartinHjelmare]

It would be good to fix that, yes.

[amelchio]

It's target in the notify service itself so I'm not sure why we would use recipient in the platforms?

https://www.home-assistant.io/components/notify/#service

[scop]

For consistency within platforms? I have no strong opinions either way, but the majority of platforms already use recipient (clickatell, clicksend, clicksend_tts, mailgun, sendgrid, smtp, xmpp, yessssms, and now huawei_lte).

[amelchio]

I'm aiming for consistency, period. Switching nine platforms over now might seem like a lot of work, but better to do it before it's twentynine ...

I also have no particular preference for either word but for usability alone, I think it should be the same everywhere.

[MartinHjelmare]

Target is easier to spell. 😄

[scop]

Recipient is more descriptive :)