Skip to content

Fix not being able to update entities#19346

Closed
emontnemery wants to merge 1 commit intohome-assistant:devfrom
emontnemery:fix_update_entities
Closed

Fix not being able to update entities#19346
emontnemery wants to merge 1 commit intohome-assistant:devfrom
emontnemery:fix_update_entities

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Dec 16, 2018

Description:

Note: This is a copy of #19344, but against dev branch, all credit for the fix goes to @glentakahashi

When editing an entity in the frontend dialog, pressing save causes a "save failed: Entity is already registered" error. This is because the frontend always sets name and new_entity_id in the websocket command even if they haven't been changed. This adds a check that the new_entity_id is actually different from entity_id before erroring that the new_entity_id is already registered.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@emontnemery emontnemery requested a review from a team as a code owner December 16, 2018 12:07
@ghost ghost assigned emontnemery Dec 16, 2018
@ghost ghost added the in progress label Dec 16, 2018
@emontnemery emontnemery added this to the 0.84.3 milestone Dec 16, 2018
@balloob balloob removed this from the 0.84.3 milestone Dec 16, 2018
@balloob balloob closed this Dec 16, 2018
@ghost ghost removed the in progress label Dec 16, 2018
@emontnemery emontnemery deleted the fix_update_entities branch December 19, 2018 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants