Skip to content

Fix missing colorTemperatureInKelvin from Alexa responses#19069

Merged
balloob merged 3 commits intohome-assistant:devfrom
mikeage:fix_alexa_color_temperature
Dec 6, 2018
Merged

Fix missing colorTemperatureInKelvin from Alexa responses#19069
balloob merged 3 commits intohome-assistant:devfrom
mikeage:fix_alexa_color_temperature

Conversation

@mikeage
Copy link
Copy Markdown
Contributor

@mikeage mikeage commented Dec 6, 2018

Description:

Related issue (if applicable): fixes #18827

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @mikeage,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@ghost ghost added the in progress label Dec 6, 2018
@balloob balloob added this to the 0.84.0 milestone Dec 6, 2018
@ghost ghost assigned balloob Dec 6, 2018
@mikeage
Copy link
Copy Markdown
Contributor Author

mikeage commented Dec 6, 2018

Thanks for helping out with the test and indentation

@balloob balloob merged commit dd92318 into home-assistant:dev Dec 6, 2018
@ghost ghost removed the in progress label Dec 6, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented Dec 6, 2018

Thanks for finding this. Helped out because I wanted to make sure it made the beta.

@mikeage mikeage deleted the fix_alexa_color_temperature branch December 6, 2018 16:34
@mikeage
Copy link
Copy Markdown
Contributor Author

mikeage commented Dec 6, 2018

Glad I could help. It took me a while to understand how HA is put together internally, but it's quite straightforward now that I'm starting to see how the different parts fit

balloob pushed a commit that referenced this pull request Dec 7, 2018
* Fix missing colorTemperatureInKelvin from Alexa responses

* Update smart_home.py

* Add test
@balloob balloob mentioned this pull request Dec 12, 2018
@stich86
Copy link
Copy Markdown

stich86 commented Mar 12, 2019

Hello,

i still have that issue when using HUE strip exposed via HA to Alexa. Change to every color doesn't give any error, but when i'm asking to switch on "white" (just white, no other type of color.. i'm italian so i'm asking "bianco"), the strip changes color but Alexa report a "Server error".

How can i help you to check and fix that issue?

thanks!

@mikeage
Copy link
Copy Markdown
Contributor Author

mikeage commented Mar 12, 2019

Best to open a new issue, I think. I found this one by adding debug and checking that the response matched what was in the docs, but it's still working for me with my devices. Maybe someone more familiar with Alexa will be able to help.

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Mar 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"I don't know what went wrong" from Alexa when setting color temperature

4 participants