Refactor script helper actions into their own methods#18962
Merged
Conversation
houndci-bot
reviewed
Dec 3, 2018
Member
Author
|
Since it's just a refactor, no new logic, will merge and then continue work on #18965 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This cleans up the script helper and puts all actions into their own methods.
Needed because now that services propagate exceptions, we need to update the edges to properly handle errors.
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: