Skip to content

Refactor script helper actions into their own methods#18962

Merged
balloob merged 3 commits intodevfrom
handle-service-not-found
Dec 3, 2018
Merged

Refactor script helper actions into their own methods#18962
balloob merged 3 commits intodevfrom
handle-service-not-found

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Dec 3, 2018

Description:

This cleans up the script helper and puts all actions into their own methods.

Needed because now that services propagate exceptions, we need to update the edges to properly handle errors.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from a team as a code owner December 3, 2018 12:35
@ghost ghost assigned balloob Dec 3, 2018
@ghost ghost added the in progress label Dec 3, 2018
@balloob balloob mentioned this pull request Dec 3, 2018
4 tasks
@balloob
Copy link
Copy Markdown
Member Author

balloob commented Dec 3, 2018

Since it's just a refactor, no new logic, will merge and then continue work on #18965

@balloob balloob merged commit d028236 into dev Dec 3, 2018
@ghost ghost removed the in progress label Dec 3, 2018
@delete-merged-branch delete-merged-branch bot deleted the handle-service-not-found branch December 3, 2018 14:46
@balloob balloob mentioned this pull request Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants