Tellduslive refactoring#18780
Conversation
|
@molobrakos, what is your take do you still want to be part in |
MartinHjelmare
left a comment
There was a problem hiding this comment.
There's use of async_add_job from sync context in the component. That should be updated to probably use add_job.
There's also a case where we register a listener for home assistant start event if session is not truthy which doesn't seem possible.
@fredrike: feel free to remove me. I already believe you also have write persmissions to the tellduslive library, right? Maybe that has to be refactored to use asyncio as well (aiohttp instead of requests)? (edit: ah, I now see that you run the updated outside of the main loop for now) |
726a4e8 to
295aa29
Compare
|
@MartinHjelmare ping 😃 . |
Description:
Move component to package and refactoring.
Related issue (if applicable): fixes #17515
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: