Add support for zha device registry#18755
Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom Dec 1, 2018
Merged
Conversation
ghost
added
the
| hass.helpers.device_registry.async_get_registry() | ||
| device_registry.async_get_or_create( | ||
| config_entry_id=config_entry.entry_id, | ||
| connections={(CONNECTION_ZIGBEE, str(APPLICATION_CONTROLLER.ieee))}, |
Member
There was a problem hiding this comment.
Are we duplicating some info in the ZhaDeviceEntity now that we add device info? Do we need to keep the ZhaDeviceEntity entity or can it be cleaned up?
Contributor
Author
There was a problem hiding this comment.
Not really. As we are not able to expose arbitrary data through device info, ZhaDeviceEntity is still needed. It is currently used for rx/tx status info, last_seen, network addresses and possibly other device level attributes like battery status in the future.
ammarfaizi2
approved these changes
Dec 1, 2018
3 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds device registry support for zha component.
Checklist:
tox. Your PR cannot be merged unless tests pass