Support for new velux api, added cover.velux by Julius2342 · Pull Request #18738 · home-assistant/core

Julius2342 · 2018-11-27T08:03:43Z

Description:

Upgraded pyvlx to version 0.2.*. Users will need to upgrade to a recent firmware version. Old and new firmwareversions are not compatible (both use a completely different API).

Added support for controlling Velux windows one by one.

Configuration should stay the same. Component will fetch the available devices/nodes from API.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7867

EDIT: Within the changelog of the release we should point to the page where the new Firmware may be downloaded: https://www.velux.com/api/klf200

WoodsterDK · 2018-12-07T06:03:49Z

Hi I noticed one issue:

async def async_open_cover(self, **kwargs):
    """Open the cover."""
    await self.node.close()

should be async def async_open_cover(self, **kwargs):
"""Open the cover."""
await self.node.open()

And

def current_cover_position(self):
    """Return the current position of the cover."""
    return 0

can be changed to support position query:

def current_cover_position(self):
    """Return the current position of the cover."""
    return self.node.current_position

Julius2342 · 2018-12-07T19:16:42Z

@WoodsterDK ty for you feedback! i already spotted the s/close/open/ - thing, but did not yet commit. I'm currently working on retrieving the current position from various feedback/status messages, but this still takes some iterations. I will post an update here if i have a working prototype :)

WoodsterDK · 2018-12-07T19:33:01Z

@Julius2342 no problem - I'm up for testing it, when you have something ready.
Let me know if you need some help.

houndci-bot · 2018-12-15T18:45:26Z

+        if ATTR_POSITION in kwargs:
+            position_percent = 100 - kwargs[ATTR_POSITION]
+            from pyvlx import Position
+            await self.node.set_position(Position(position_percent=position_percent))


line too long (85 > 79 characters)

Julius2342 · 2018-12-15T19:34:01Z

@WoodsterDK ^^

WoodsterDK · 2018-12-19T11:32:18Z

Hi,
The covers are not being inserted as entities.

I think there might be an issue if no scenes are present
I have seen an "out of index"

Julius2342 · 2018-12-19T13:36:53Z

@WoodsterDK : do you get any error when initializing the the component? It should load all entities automatically on startup:

    async def async_start(self):
        """Start velux component."""
        await self.pyvlx.load_scenes()
        await self.pyvlx.load_nodes()

Julius2342 · 2018-12-19T17:48:34Z

@WoodsterDK : may you retry?

WoodsterDK · 2018-12-19T18:38:09Z

@WoodsterDK : may you retry?

@Julius2342 Will test tomorrow...
Could it be caused by a combination with the switches I have? - the nodeIDs for my covers might not come in a numerical order due to the switches.
Do you lookup in the node array according to the nodeID or by an index found by searching for the nodeID?

Julius2342 · 2018-12-19T19:15:23Z

@WoodsterDK : When retrieving the scenes, my old implementation was waiting for the last FrameGetSceneListNotification with remaining_scenes==0. If in your implementation no scenes are configured, this frame is never sent, the whole thing runs into a timeout and an exception is raised that the scene list was not retrieved.

Julius2342 · 2018-12-19T19:54:10Z

@WoodsterDK : And you are right, there was another bug with accessing the nodes via index-id instead of node_id (which makes more sense).

WoodsterDK · 2018-12-20T08:31:40Z

@WoodsterDK : And you are right, there was another bug with accessing the nodes via index-id instead of node_id (which makes more sense).

OK - just tried running with the updated library, and my covers seems to added as entities - GREAT.
I can control them, but it seems the position is not being correctly reflected.

Furthermore it could be nice to add the support of the feature cover.stop_cover in the component.

If I look in the log every 10 second there is this:

Even if there is no movement of the covers - do you poll for states from the products, or is it only the internal values that are being "broadcastet"?

Julius2342 · 2018-12-20T08:36:11Z

what do you mean with not being correctly reflected. . I'dont know what the correct correlation is.

WRT cover.stop, do you know which Frame to send?

No i do not poll. I activated the house-monitor. During movement they broadcast their position from time to time. Does this stop after the covers reached their final position?

WoodsterDK · 2018-12-24T12:46:02Z

@Julius2342 Great work - a couple of things:

notification of position seems to be working, if the slider is being used.
stop works
position is being messed up when the movement is stopped by pressing "Stop"

jpearce73 · 2019-01-17T05:33:29Z

Thanks for this work, I'd love to try it out.
I just upgraded homeassistant to 0.85.1. I found the components/velux.py and discovered its still the old version. Where do I learn how to pull pre-release change set like this?

apeeters · 2019-01-18T11:25:25Z

I tested this branch and it works works perfectly. Thanks for the great work! Can't wait to have it merged :)

WoodsterDK · 2019-01-18T11:46:38Z

@Julius2342 have you had a chance to look at:

notification of position seems to be working, if the slider is being used.
stop works
position is being messed up when the movement is stopped by pressing "Stop"

Julius2342 · 2019-01-18T12:38:45Z

@WoodsterDK : Yes, started a small refactoring but then I was interrupted. Will try to continue soon.

apeeters · 2019-01-18T12:44:27Z

@WoodsterDK I did not experience that problem when pressing stop.

WoodsterDK · 2019-01-18T16:15:54Z

@apeeters if you operate the cover, press stop close the ui card and open it again, the slider is positioned in a wrong position

apeeters · 2019-01-19T10:57:43Z

@WoodsterDK @Julius2342 I was able to reproduce this. It does not always occur and is caused by negative position values. Initially all my covers (closed) have position -23, after moving and stopping I sometimes get -5.

l-mb · 2019-01-23T16:46:32Z

Very interested in seeing this merged, let me know if I can test via a beta channel/repo for hass.io.

Julius2342 · 2019-01-28T12:26:52Z

@WoodsterDK may you retry?

WoodsterDK · 2019-01-29T08:00:18Z

@Julius2342 Sure thing - will see if I can fit in try today

marchingphoenix · 2019-01-29T17:55:50Z

+    @callback
+    def async_register_callbacks(self):
+        """Register callbacks to update hass after device was changed."""
+        async def after_update_callback(device):


Question, should the async def be outside of the def? I'm not 100% familiar with this yet.
example: cover.template.pyL201

I think that's okay, as it is just passed as a callback (which I assume gets awaited later on). The @callback marks this as something that does not do I/O (for optimization), see: https://developers.home-assistant.io/docs/en/asyncio_categorizing_functions.html#the-callback-function

WoodsterDK · 2019-01-29T18:54:07Z

@WoodsterDK may you retry?

@Julius2342 - just tested, with the reference to 'pyvlx==0.2.8' it seems to be working as expected... COOL :)

rytilahti · 2019-01-29T23:52:07Z

Added the 'breaking change' label as according to the initial descriptions this will be such for existing users.

rytilahti · 2019-01-29T23:54:28Z

            host=host,
-            password=password)
+            password=password,
+            log_frames=True)


What does this option do as it sounds like a debugging option, and why is it wanted here? Otherwise (considering the reports that this is working on real devices) this should be ready to be merged.

I removed this parameter!

Julius2342 · 2019-01-31T17:30:19Z

@rytilahti : I addressed your issue.

rytilahti · 2019-02-01T01:13:16Z

Thanks! 👍 I bolded the need to mention this in the changelog (inside description), as I don't think we have a label to highlight specific parts at the moment.

MartinHjelmare

Good! Just a small comment.

MartinHjelmare · 2019-02-01T09:39:39Z

+
+    async def async_set_cover_position(self, **kwargs):
+        """Move the cover to a specific position."""
+        if ATTR_POSITION in kwargs:


This is already validated by the service schema.

Support for new velux api, added cover.velux

6f94e13

homeassistant added cla-signed integration: velux new-platform platform: cover.velux labels Nov 27, 2018

ghost added the in progress label Nov 27, 2018

Julius2342 added 3 commits November 29, 2018 23:33

Merge remote-tracking branch 'upstream/dev' into new-velux-api

e21d6fb

More steps on new velux covers.

f88766c

Merge branch 'dev' into new-velux-api

6a9e13d

Julius2342 added 2 commits December 15, 2018 19:44

correct position handling of velux windows

6a7aaab

Merge remote-tracking branch 'upstream/dev' into new-velux-api

5af2b09

houndci-bot reviewed Dec 15, 2018

View reviewed changes

Following suggestion from hound.

3968a5f

Julius2342 changed the title ~~[WIP] Support for new velux api, added cover.velux~~ Support for new velux api, added cover.velux Dec 15, 2018

Julius2342 mentioned this pull request Dec 15, 2018

WIP Documentation for cover.velux added home-assistant/home-assistant.io#7867

Closed

2 tasks

Merge remote-tracking branch 'upstream/dev' into new-velux-api

abfd9e0

Julius2342 mentioned this pull request Dec 17, 2018

new api Julius2342/pyvlx#10

Closed

bumped version

7b706f7

Julius2342 added 2 commits December 25, 2018 12:40

Merge remote-tracking branch 'upstream/dev' into new-velux-api

a485798

Merge remote-tracking branch 'upstream/dev' into new-velux-api

f3c934c

Julius2342 added 2 commits January 27, 2019 13:57

Merge remote-tracking branch 'upstream/dev' into new-velux-api

15d1de8

Bumped version to 0.2.8

13822bb

marchingphoenix reviewed Jan 29, 2019

View reviewed changes

rytilahti added the breaking-change label Jan 29, 2019

rytilahti approved these changes Jan 29, 2019

View reviewed changes

removed log_frames parameter

4828212

rytilahti merged commit 7479410 into home-assistant:dev Feb 1, 2019

ghost removed the in progress label Feb 1, 2019

MartinHjelmare reviewed Feb 1, 2019

View reviewed changes

rytilahti added the new-feature label Feb 1, 2019

Julius2342 mentioned this pull request Feb 16, 2019

Added sentence about required firmware version of Velux component. home-assistant/home-assistant.io#8606

Merged

balloob mentioned this pull request Feb 20, 2019

0.88.0 #21238

Merged

ghost removed the platform: cover.velux label Mar 21, 2019

Uh oh!

Conversation

Julius2342 commented Nov 27, 2018 • edited by rytilahti Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Uh oh!

WoodsterDK commented Dec 7, 2018

Uh oh!

Julius2342 commented Dec 7, 2018

Uh oh!

WoodsterDK commented Dec 7, 2018

Uh oh!

houndci-bot Dec 15, 2018

Choose a reason for hiding this comment

Uh oh!

Julius2342 commented Dec 15, 2018

Uh oh!

WoodsterDK commented Dec 19, 2018

Uh oh!

Julius2342 commented Dec 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Julius2342 commented Dec 19, 2018

Uh oh!

WoodsterDK commented Dec 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Julius2342 commented Dec 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Julius2342 commented Dec 19, 2018

Uh oh!

WoodsterDK commented Dec 20, 2018

Uh oh!

Julius2342 commented Dec 20, 2018

Uh oh!

WoodsterDK commented Dec 24, 2018

Uh oh!

jpearce73 commented Jan 17, 2019

Uh oh!

apeeters commented Jan 18, 2019

Uh oh!

WoodsterDK commented Jan 18, 2019

Uh oh!

Julius2342 commented Jan 18, 2019

Uh oh!

apeeters commented Jan 18, 2019

Uh oh!

WoodsterDK commented Jan 18, 2019

Uh oh!

apeeters commented Jan 19, 2019

Uh oh!

l-mb commented Jan 23, 2019

Uh oh!

Julius2342 commented Jan 28, 2019

Uh oh!

WoodsterDK commented Jan 29, 2019

Uh oh!

marchingphoenix Jan 29, 2019

Choose a reason for hiding this comment

Uh oh!

rytilahti Jan 29, 2019

Choose a reason for hiding this comment

Uh oh!

WoodsterDK commented Jan 29, 2019

Uh oh!

rytilahti commented Jan 29, 2019

Uh oh!

rytilahti Jan 29, 2019

Choose a reason for hiding this comment

Uh oh!

Julius2342 Jan 30, 2019

Choose a reason for hiding this comment

Uh oh!

Julius2342 commented Jan 31, 2019

Uh oh!

rytilahti commented Feb 1, 2019

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Julius2342 commented Nov 27, 2018 •

edited by rytilahti

Loading

Julius2342 commented Dec 19, 2018 •

edited

Loading

WoodsterDK commented Dec 19, 2018 •

edited

Loading

Julius2342 commented Dec 19, 2018 •

edited

Loading