Follow-up: remove pbkdf2 to bcrypt upgrade path#18736
Merged
balloob merged 1 commit intohome-assistant:devfrom Nov 27, 2018
Eriner:remove-pbkdf2-upgrade-path
Merged
Follow-up: remove pbkdf2 to bcrypt upgrade path#18736balloob merged 1 commit intohome-assistant:devfrom Eriner:remove-pbkdf2-upgrade-path
balloob merged 1 commit intohome-assistant:devfrom
Eriner:remove-pbkdf2-upgrade-path
Conversation
ghost
added
the
Eriner
commented
Nov 27, 2018
| assert user.is_active | ||
|
|
||
|
|
||
| async def test_new_hashes_are_bcrypt(data, hass): |
Contributor
Author
There was a problem hiding this comment.
We could leave this test in.
balloob
approved these changes
Nov 27, 2018
Member
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
This looks good.
Not going to mark this as a breaking change as this is only a breaking change if you enabled auth 2 versions before it was enabled by default and have not used auth since .
Eriner
added a commit
to Eriner/home-assistant
that referenced
this pull request
Dec 4, 2018
user['salt'] was originally used as a part of the pbkdf2 implementation. I failed to remove this as a part of the cleanup in home-assistant#18736.
balloob
pushed a commit
that referenced
this pull request
Dec 4, 2018
user['salt'] was originally used as a part of the pbkdf2 implementation. I failed to remove this as a part of the cleanup in #18736.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
As discussed in #16071, now 90+ days later, I think it's safe to remove the pbkdf2 -> bcrypt upgrade path. Any users who had the new auth system enabled should at this point now be using bcrypt hashes, thus the upgrade path functionality and related tests should be safe to remove.
Related issue (if applicable): Removes legacy upgrade as discussed in #16071
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests pass