Add ability to monitor relay events#18730
Merged
Merged
Conversation
2 tasks
Contributor
Author
|
This is ready to go. Any reason it has sat for so long? |
balloob
approved these changes
Jan 11, 2019
Member
|
We were on a break and had over 190 open PRs, things take time… |
| entry = self.device.get_schedule_entry(event, str(relay)) | ||
| entry.output.append(output) | ||
| resp = self.device.change_schedule(entry) | ||
| return resp |
Member
There was a problem hiding this comment.
Is this return correct? It looks weird in this place. Also, nothing is checking the return value of this method.
Contributor
Author
There was a problem hiding this comment.
The return is unnecessary, but shouldn't cause any problems since the calling code does not expect a return value. I have some other housekeeping tasks planned for this component and will clean this up as part of those changes.
Member
There was a problem hiding this comment.
Should we really return inside the loop?
Contributor
Author
There was a problem hiding this comment.
Nope. You're right. Guess I'll go ahead and knock out those changes...
6 tasks
Merged
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Feb 12, 2019
* Add ability to monitor relay events * Account for empty events array instead of none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Enables ability to trigger actions in Home Assistant when Doorbird relay is triggered.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7648
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.