Conversation
ghost
assigned
houndci-bot
reviewed
Nov 24, 2018
houndci-bot
reviewed
Nov 25, 2018
balloob
force-pushed
the
cloud-webhooks
branch
from
34e1f5f to
3b500e6
Compare
balloob
changed the title
pvizeli
reviewed
Nov 26, 2018
pvizeli
approved these changes
Nov 26, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This adds foundation for cloud-extension of webhooks. Allow managing via frontend. Handling incoming webhooks from relayer will be done in another PR.
WIP because I am not done yet with adding tests.
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: