Skip to content

Support for mulitple Blink sync modules#18663

Merged
dgomes merged 1 commit intohome-assistant:devfrom
fronzbot:blink-multi-sync-support
Dec 3, 2018
Merged

Support for mulitple Blink sync modules#18663
dgomes merged 1 commit intohome-assistant:devfrom
fronzbot:blink-multi-sync-support

Conversation

@fronzbot
Copy link
Copy Markdown
Contributor

@fronzbot fronzbot commented Nov 24, 2018

Description:

The blinkpy library added support for multiple sync modules with the most recent release, so I rolled those changes in here.

Example entry for configuration.yaml (if applicable):

blink:
  username: <username>
  password: <password>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@fronzbot
Copy link
Copy Markdown
Contributor Author

Breaking Change:
Blink alarm control panel now inherits the name of the actual sync module rather than defaulting to blink_sync

Copy link
Copy Markdown
Contributor

@dgomes dgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fronzbot
Copy link
Copy Markdown
Contributor Author

fronzbot commented Dec 3, 2018

@dgomes anybody I should CC to get this looked at/merged? I feel like it has been lost in the shuffle and want to make sure it gets in before next release (it would be great if it was in the beta, actually)

@dgomes dgomes merged commit 4486de7 into home-assistant:dev Dec 3, 2018
@ghost ghost removed the Ready for review label Dec 3, 2018
@dgomes
Copy link
Copy Markdown
Contributor

dgomes commented Dec 3, 2018

Sorry for holding this PR for so long :(

🎉

@balloob balloob mentioned this pull request Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants