Skip to content

AirVisual: Show icon for air pollution level, based on its value#18482

Merged
bachya merged 1 commit intohome-assistant:devfrom
leppa:airvisual
Nov 15, 2018
Merged

AirVisual: Show icon for air pollution level, based on its value#18482
bachya merged 1 commit intohome-assistant:devfrom
leppa:airvisual

Conversation

@leppa
Copy link
Copy Markdown
Contributor

@leppa leppa commented Nov 15, 2018 •
edited
Loading

Description:

Show excited, happy, neutral, sad, dead emoticon, or biohazard icon, based on air pollution level.

Also, fix a small typo and change air quality index icon to mdi:chart-line. Seems a bit more logical.

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: airvisual
    api_key: YOUR_AIRVISUAL_API_KEY

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@leppa leppa requested a review from bachya as a code owner November 15, 2018 13:05
@ghost ghost added the in progress label Nov 15, 2018
@leppa
AirVisual: Show icon for air pollution level, based on its value
bbe61fa 
Show excited, happy, neutral, sad, dead emoticon, or biohazard icon,
based on air pollution level.

Also, fix a small typo and change air quality index icon to
`mdi:chart-line`. Seems a bit more logical.
bachya
bachya requested changes Nov 15, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@bachya bachya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Small comment.

@bachya bachya merged commit d1b5bc1 into home-assistant:dev Nov 15, 2018
@ghost ghost removed the in progress label Nov 15, 2018
@bachya
Copy link
Copy Markdown
Contributor

bachya commented Nov 15, 2018

Thank you! 😎

@leppa leppa deleted the airvisual branch November 15, 2018 17:30
@balloob balloob mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bachya bachya bachya approved these changes

Assignees

No one assigned

Labels

cla-signed integration: airvisual small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leppa @bachya @homeassistant