Skip to content

Updated pydaikin version#18413

Merged
fabaff merged 1 commit intohome-assistant:devfrom
fredrike:daikin-fixes
Nov 12, 2018
Merged

Updated pydaikin version#18413
fabaff merged 1 commit intohome-assistant:devfrom
fredrike:daikin-fixes

Conversation

@fredrike
Copy link
Copy Markdown
Contributor

Description:

Related issue (if applicable): fixes #13111

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit c6683cb into home-assistant:dev Nov 12, 2018
@ghost ghost removed the in progress label Nov 12, 2018
@fredrike
Copy link
Copy Markdown
Contributor Author

Found an issue in the new pydaikin, should I open a new pr?

@fabaff
Copy link
Copy Markdown
Member

fabaff commented Nov 12, 2018

Yes, please.

@fabaff
Copy link
Copy Markdown
Member

fabaff commented Nov 12, 2018

Sorry, if I was too fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Daikin climate resets temperature

4 participants