Skip to content

Fix default value for optional Sense configuration parameter#18379

Merged
balloob merged 1 commit intohome-assistant:devfrom
claytonjn:claytonjn-sense-official
Nov 11, 2018
Merged

Fix default value for optional Sense configuration parameter#18379
balloob merged 1 commit intohome-assistant:devfrom
claytonjn:claytonjn-sense-official

Conversation

@claytonjn
Copy link
Copy Markdown
Contributor

Description:

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @claytonjn,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@ghost ghost added the in progress label Nov 11, 2018
@balloob balloob added this to the 0.82.1 milestone Nov 11, 2018
@balloob balloob merged commit 1f47693 into home-assistant:dev Nov 11, 2018
@ghost ghost removed the in progress label Nov 11, 2018
@balloob balloob mentioned this pull request Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants