huawei_router: fix last device being ignored#18329
Merged
amelchio merged 1 commit intohome-assistant:devfrom Nov 9, 2018
Merged
huawei_router: fix last device being ignored#18329amelchio merged 1 commit intohome-assistant:devfrom
amelchio merged 1 commit intohome-assistant:devfrom
Conversation
homeassistant
added
cla-signed
integration: device_tracker
core
small-pr
ghost
added
the
amelchio
approved these changes
Nov 9, 2018
Contributor
|
I guess that's why we prefer this kind of stuff in external libraries 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The regex was not matching the last device on the list, so it was never added to HA.
Checklist:
tox. Your PR cannot be merged unless tests pass