Skip to content

Webhook names#18206

Merged
pvizeli merged 2 commits intodevfrom
webhook-names
Nov 5, 2018
Merged

Webhook names#18206
pvizeli merged 2 commits intodevfrom
webhook-names

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Nov 4, 2018

Description:

It's currently not possible for users to see which webhooks are active or were they came from. This adds domain and name to webhooks and allows to query them in the UI.

This required us to pass more info to async_trigger for automations, as the webhook automation trigger needs to pass the name to the webhook. So we did just that.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from a team as a code owner November 4, 2018 20:46
@ghost ghost assigned balloob Nov 4, 2018
@ghost ghost added the in progress label Nov 4, 2018
@pvizeli pvizeli merged commit 2e91328 into dev Nov 5, 2018
@ghost ghost removed the in progress label Nov 5, 2018
@pvizeli pvizeli deleted the webhook-names branch November 5, 2018 08:24
@balloob balloob mentioned this pull request Nov 29, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants