Melissa state_attributes#18201
Merged
balloob merged 4 commits intohome-assistant:devfrom Nov 6, 2018
kennedyshead:melissa_state_attribute
Merged
Melissa state_attributes#18201balloob merged 4 commits intohome-assistant:devfrom kennedyshead:melissa_state_attribute
balloob merged 4 commits intohome-assistant:devfrom
kennedyshead:melissa_state_attribute
Conversation
homeassistant
added
platform: climate.melissa
small-pr
ghost
added
the
balloob
requested changes
Nov 4, 2018
balloob
reviewed
Nov 5, 2018
balloob
reviewed
Nov 5, 2018
2 tasks
balloob
pushed a commit
that referenced
this pull request
Nov 5, 2018
2 tasks
Member
|
Would this be considered a breaking change? |
Contributor
Author
|
Its the removal of sensors that are breaking imo |
Member
|
Good point, this is not a breaking change. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
They are sensors atm. but I think state_attributes would be far better
Checklist:
tox. Your PR cannot be merged unless tests pass