Add Traccar device tracker#18200
Conversation
| vol.Required(CONF_USERNAME): cv.string, | ||
| vol.Required(CONF_HOST): cv.string, | ||
| vol.Optional(CONF_PORT, default=8082): cv.port, | ||
| vol.Optional(CONF_SSL, default=False): cv.boolean, |
There was a problem hiding this comment.
I would suggest that we are using a secured channel for the communication by default, if possible.
There was a problem hiding this comment.
It is possible, but I think that would confuse the potential enduser?
Home Assistant itself and most of the components/platforms do have this as false by defaul?
git grep "CONF_SSL, default=True"
homeassistant/components/sensor/synologydsm.py: vol.Optional(CONF_SSL, default=True): cv.boolean,git grep "CONF_SSL, default=False"
homeassistant/components/binary_sensor/hikvision.py: vol.Optional(CONF_SSL, default=False): cv.boolean,
homeassistant/components/device_tracker/netgear.py: vol.Optional(CONF_SSL, default=False): cv.boolean,
homeassistant/components/device_tracker/tomato.py: vol.Optional(CONF_SSL, default=False): cv.boolean,
homeassistant/components/device_tracker/traccar.py: vol.Optional(CONF_SSL, default=False): cv.boolean,
homeassistant/components/media_player/epson.py: vol.Optional(CONF_SSL, default=False): cv.boolean,
homeassistant/components/octoprint.py: vol.Optional(CONF_SSL, default=False): cv.boolean,
homeassistant/components/sensor/nzbget.py: vol.Optional(CONF_SSL, default=False): cv.boolean,
homeassistant/components/sensor/pyload.py: vol.Optional(CONF_SSL, default=False): cv.boolean,
homeassistant/components/sensor/qnap.py: vol.Optional(CONF_SSL, default=False): cv.boolean,
homeassistant/components/sensor/radarr.py: vol.Optional(CONF_SSL, default=False): cv.boolean,
homeassistant/components/sensor/sma.py: vol.Optional(CONF_SSL, default=False): cv.boolean,
homeassistant/components/sensor/sonarr.py: vol.Optional(CONF_SSL, default=False): cv.boolean,
homeassistant/components/splunk.py: vol.Optional(CONF_SSL, default=False): cv.boolean,git grep "DEFAULT_SSL ="
homeassistant/components/binary_sensor/concord232.py:DEFAULT_SSL = False
homeassistant/components/binary_sensor/nx584.py:DEFAULT_SSL = False
homeassistant/components/climate/venstar.py:DEFAULT_SSL = False
homeassistant/components/device_tracker/ddwrt.py:DEFAULT_SSL = False
homeassistant/components/device_tracker/luci.py:DEFAULT_SSL = False
homeassistant/components/media_player/emby.py:DEFAULT_SSL = False
homeassistant/components/media_player/firetv.py:DEFAULT_SSL = False
homeassistant/components/media_player/itunes.py:DEFAULT_SSL = False
homeassistant/components/rainmachine/__init__.py:DEFAULT_SSL = True
homeassistant/components/sabnzbd.py:DEFAULT_SSL = False
homeassistant/components/sensor/influxdb.py:DEFAULT_SSL = False
homeassistant/components/sensor/mfi.py:DEFAULT_SSL = True
homeassistant/components/sensor/pi_hole.py:DEFAULT_SSL = False
homeassistant/components/sensor/plex.py:DEFAULT_SSL = False
homeassistant/components/sensor/tautulli.py:DEFAULT_SSL = False
homeassistant/components/splunk.py:DEFAULT_SSL = False
homeassistant/components/switch/mfi.py:DEFAULT_SSL = True
homeassistant/components/zabbix.py:DEFAULT_SSL = False
homeassistant/components/zoneminder/__init__.py:DEFAULT_SSL = FalseThere was a problem hiding this comment.
I do not disagree with the suggestion, but to my knowledge, there is not a standard that a component or a platform should have that enabled by default, it may be something to discuss in https://github.com/home-assistant/architecture?
There was a problem hiding this comment.
I think it makes a difference where the target is located. Devices on the LAN usually do not have valid certificates anyway.
Connections to servers on the internet should default to SSL with verification.
There was a problem hiding this comment.
I'm not sure if their paid service is running SSL, but the demo versions are not.
For the local version they do not have built-in support for SSL, you would have to run it behind a proxy to get that for a local instance.
I have used a local instance (hassio add-on) while building and testing this.
amelchio
left a comment
There was a problem hiding this comment.
This looks good to me but I am no device_tracker wizard.
|
very nice indeed :) was using a custom component before which i tweaked with battery etc... any chances that monitored conditions could be added to this to allow additional fields? factoring in if two devices have different fields available etc... then sir you will be a god lol |
|
Please open an issue if you suspect a bug. If you need help please use our help channels: Merged PRs should not be used for support or bug reports. Thanks! |
Description:
Adds
traccaras a new GPS device tracker.This platform has support for over 1500 different types of devices.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7364
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: