Skip to content

Add more type hints to helpers#18196

Merged
balloob merged 5 commits intohome-assistant:devfrom
scop:typing-helpers
Nov 4, 2018
Merged

Add more type hints to helpers#18196
balloob merged 5 commits intohome-assistant:devfrom
scop:typing-helpers

Conversation

@scop
Copy link
Copy Markdown
Member

@scop scop commented Nov 4, 2018

Description:

Add more type hints to helpers.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@scop scop requested a review from a team as a code owner November 4, 2018 16:46
@ghost ghost assigned scop Nov 4, 2018
@ghost ghost added the in progress label Nov 4, 2018
from .typing import HomeAssistantType

if TYPE_CHECKING:
import astral # pylint: disable=unused-import
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'astral' imported but unused

@balloob balloob merged commit 922f34f into home-assistant:dev Nov 4, 2018
@ghost ghost removed the in progress label Nov 4, 2018
@scop scop deleted the typing-helpers branch November 5, 2018 16:01
@balloob balloob mentioned this pull request Nov 29, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants