Conversation
homeassistant
added
cla-signed
platform: image_processing.tensorflow
small-pr
Member
Author
balloob
approved these changes
Nov 4, 2018
Member
|
You are correct that the wheel is not available on all platforms, but if it is self compiled and pre-installed before this component runs, the component should use it, correct? Why not keep it here for those who do have it available to remove an additional step? I suppose that removing it also allows a user to choose gpu or cpu if their setup supports it, so not totally against it. |
Member
Author
|
Because it breaks all build system they have not the wheels. It's the same with dlib and OpenCV. wee need run a solution they bring the best compatibility. |
balloob
pushed a commit
that referenced
this pull request
Nov 5, 2018
* Handle TensorFlow like OpenCV * Update requirements_all.txt
Merged
ghost
added
integration: tensorflow
and removed
platform: image_processing.tensorflow
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
That is the same problem as we have with OpenCV. The python wheels are not available for all platforms (amd64/i386/arm/aarch64) and OS.
With this change, the user needs self-install TensorFlow like OpenCV. Need also an update on Documentation.