Skip to content

Update Coinbase icons#18172

Merged
fabaff merged 3 commits intohome-assistant:devfrom
tjorim:coinbase-icons
Nov 4, 2018
Merged

Update Coinbase icons#18172
fabaff merged 3 commits intohome-assistant:devfrom
tjorim:coinbase-icons

Conversation

@tjorim
Copy link
Copy Markdown
Contributor

@tjorim tjorim commented Nov 3, 2018

Description:

This PR adds extra icons (EUR, LTC, USD) and puts them in a dictionary.
Furthermore, it doesn't rely on the name anymore but the actual currency.
We get the icon from the dict with a safe get() and default value as before.

Related issue (if applicable): fixes # NA

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here> NA

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

and don't rely on the name
use safe get() with default value
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🐦

@fabaff fabaff merged commit 42cb23f into home-assistant:dev Nov 4, 2018
@tjorim tjorim deleted the coinbase-icons branch November 4, 2018 10:40
@balloob balloob mentioned this pull request Nov 29, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants