Skip to content

Rename huawei_lte.py to test_huawei_lte.py#18170

Merged
amelchio merged 1 commit intohome-assistant:devfrom
tjorim:patch-1
Nov 4, 2018
Merged

Rename huawei_lte.py to test_huawei_lte.py#18170
amelchio merged 1 commit intohome-assistant:devfrom
tjorim:patch-1

Conversation

@tjorim
Copy link
Copy Markdown
Contributor

@tjorim tjorim commented Nov 3, 2018

Description:

I think all test script names should start with test_ (which also sorts the list alphabetically correct)

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant homeassistant added small-pr PRs with less than 30 lines. cla-signed labels Nov 3, 2018
@ghost ghost added the in progress label Nov 3, 2018
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@amelchio amelchio merged commit 5dd691e into home-assistant:dev Nov 4, 2018
@ghost ghost removed the in progress label Nov 4, 2018
@tjorim tjorim deleted the patch-1 branch November 4, 2018 10:40
@balloob balloob mentioned this pull request Nov 29, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants