Skip to content

add service to reconnect the bot#18142

Merged
balloob merged 1 commit intohome-assistant:devfrom
hobbypunk90:hangouts_reconnect_service
Nov 5, 2018
Merged

add service to reconnect the bot#18142
balloob merged 1 commit intohome-assistant:devfrom
hobbypunk90:hangouts_reconnect_service

Conversation

@hobbypunk90
Copy link
Copy Markdown
Contributor

@hobbypunk90 hobbypunk90 commented Nov 3, 2018

Description:

Adds a service for reconnecting the hangups bot.

Related issue (if applicable): workaround for #17622

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7347

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Nov 3, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented Nov 3, 2018

Why can't we detect disconnects and reconnect automatically?

@hobbypunk90
Copy link
Copy Markdown
Contributor Author

sadly the hangups lib don't supports it completly, it looks like, there are some scenarios where the lib can detect a disconnect and can automatic reconnect.
But they don't reconnect, or react, if the ip address changes. No exception, no event, nothing happens there...

@balloob balloob merged commit 8de79ed into home-assistant:dev Nov 5, 2018
@ghost ghost removed the in progress label Nov 5, 2018
@balloob balloob mentioned this pull request Nov 29, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants