Disable upnp from being discovered

[balloob]

Description:

This disables upnp component from being discovered.

I realized that by making this discoverable, we are now suggesting every new user to open a port on their router and expose Home Assistant. We shouldn't do this.

[houndci-bot]

Some files could not be reviewed due to errors:

Traceback (most recent call last):

Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

[StevenLooman]

As per #18066

StevenLooman commented 4 hours ago

Apparently upnp is forbidden completely from now on via #17937 by @pvizeli. While I agree with the danger by of the port forward, it was included after discussion with @dgomes.

Still, simply disabling discovery, effectively destroying the functionality was a bit of an overkill. @pvizeli was there no other way, such as discussing this with @dgomes or me about other options?

dgomes commented 4 hours ago

It would be dangerous if auto-discovery would enable the port-forwarding automatically. But users still needed to tick the option to open the port. Or did I miss a step ?

StevenLooman commented 4 hours ago

I agree that it is too easy to enable the port-forward. If a user does not know what it is, it is very easy to simply tick it.

If a port-forward can only be enabled via the configuration file, then users will be safer.

dgomes commented 4 hours ago

On the other hand the all point of using UPnP to port-forward stuff is not to mess with configurations :)

I think a warning in the GUI should have been enough

(BTW I think these comments should be moved to the other thread)

[StevenLooman]

A solution would be that port-forward can only be enabled by using the configuration and not showing the port-forward option in the Integrations menu