Skip to content

Switch mailgun webhooks to the new Mailgun webhook api#17919

Merged
balloob merged 5 commits intohome-assistant:devfrom
rohankapoorcom:new-mailgun-webhook-api
Oct 30, 2018
Merged

Switch mailgun webhooks to the new Mailgun webhook api#17919
balloob merged 5 commits intohome-assistant:devfrom
rohankapoorcom:new-mailgun-webhook-api

Conversation

@rohankapoorcom
Copy link
Copy Markdown
Member

@rohankapoorcom rohankapoorcom commented Oct 28, 2018

Description:

Home Assistant currently supports webhooks from the mailgun event api. Mailgun released a new webhook api [reference docs] which is much better (uses JSON!) and provides signed payloads for authentication.

Since we've already merged in a breaking change to dev for mailgun (migrating to the webhook component #17464 (slated for the 0.82.0 release) which requires users to make changes to their mailgun configuration to get events into Home Assistant, we could avoid a second breaking change by switching to the new api now.

Related issue (if applicable): related to #17464

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7208

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Copy link
Copy Markdown

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

Copy link
Copy Markdown

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@rohankapoorcom
Copy link
Copy Markdown
Member Author

This required a change to the strings.json. I didn't see anything in the docs that mentioned how to handle string changes when things are already translated. I ran a find/replace across all of them - let me know if there's a different way I should have handled that.

Copy link
Copy Markdown

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

Copy link
Copy Markdown

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@balloob balloob merged commit f0693f6 into home-assistant:dev Oct 30, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented Oct 30, 2018

🎉

@ghost ghost removed the in progress label Oct 30, 2018
@rohankapoorcom rohankapoorcom deleted the new-mailgun-webhook-api branch October 30, 2018 14:31
@balloob balloob mentioned this pull request Nov 9, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants