Switch mailgun webhooks to the new Mailgun webhook api#17919
Merged
balloob merged 5 commits intohome-assistant:devfrom Oct 30, 2018
Merged
Switch mailgun webhooks to the new Mailgun webhook api#17919balloob merged 5 commits intohome-assistant:devfrom
balloob merged 5 commits intohome-assistant:devfrom
Conversation
houndci-bot
reviewed
Oct 28, 2018
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last):
File "/home/linters/.local/bin/flake8", line 7, in
from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
houndci-bot
reviewed
Oct 28, 2018
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last):
File "/home/linters/.local/bin/flake8", line 7, in
from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
Member
Author
|
This required a change to the strings.json. I didn't see anything in the docs that mentioned how to handle string changes when things are already translated. I ran a find/replace across all of them - let me know if there's a different way I should have handled that. |
2 tasks
houndci-bot
reviewed
Oct 28, 2018
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last):
File "/home/linters/.local/bin/flake8", line 7, in
from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
balloob
reviewed
Oct 29, 2018
houndci-bot
reviewed
Oct 29, 2018
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last):
File "/home/linters/.local/bin/flake8", line 7, in
from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
balloob
reviewed
Oct 29, 2018
balloob
reviewed
Oct 29, 2018
balloob
approved these changes
Oct 30, 2018
Member
|
🎉 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Home Assistant currently supports webhooks from the mailgun event api. Mailgun released a new webhook api [reference docs] which is much better (uses JSON!) and provides signed payloads for authentication.
Since we've already merged in a breaking change to dev for mailgun (migrating to the webhook component #17464 (slated for the 0.82.0 release) which requires users to make changes to their mailgun configuration to get events into Home Assistant, we could avoid a second breaking change by switching to the new api now.
Related issue (if applicable): related to #17464
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7208
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: