Skip to content

Lovelace: Move migrate to separate WS command#17890

Merged
balloob merged 1 commit intodevfrom
migrate-lovelace
Oct 27, 2018
Merged

Lovelace: Move migrate to separate WS command#17890
balloob merged 1 commit intodevfrom
migrate-lovelace

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Oct 27, 2018

Description:

Move Lovelace migration to a separate WS command, to be called by UI after confirming with the user.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.81.1 milestone Oct 27, 2018
@balloob balloob requested a review from a team as a code owner October 27, 2018 20:02
@ghost ghost assigned balloob Oct 27, 2018
@ghost ghost added the in progress label Oct 27, 2018
Copy link
Copy Markdown

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@zsarnett
Copy link
Copy Markdown
Contributor

I believe this is a good compromise. Will this auto set new users up UI Editing? I think asking current users is a good idea as it would change the way they currently write their files. But new users should have to opt out as we want to push users to use the UI editor

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Oct 27, 2018

This will set up new users automatically, as they have no cards, so no cards that need IDs

@balloob balloob merged commit 9cd8a86 into dev Oct 27, 2018
@ghost ghost removed the in progress label Oct 27, 2018
@balloob balloob deleted the migrate-lovelace branch October 27, 2018 21:51
balloob added a commit that referenced this pull request Oct 27, 2018
@balloob balloob mentioned this pull request Oct 27, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants